Skip to content

Commit

Permalink
refactor(ivy): remove i18nLocalize instruction (angular#31609)
Browse files Browse the repository at this point in the history
This has been replaced by the `$localize` tag.

PR Close angular#31609
  • Loading branch information
petebacondarwin authored and mhevery committed Aug 30, 2019
1 parent fa79f51 commit c024d89
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const angularFiles = setup({

const htmlParser = new HtmlParser();

// TODO: update translation extraction RegExp to support i18nLocalize calls once #28689 lands.
// TODO: update translation extraction RegExp to support `$localize` tags.
const EXTRACT_GENERATED_TRANSLATIONS_REGEXP =
/const\s*(.*?)\s*=\s*goog\.getMsg\("(.*?)",?\s*(.*?)\)/g;

Expand Down
1 change: 0 additions & 1 deletion packages/compiler/src/render3/r3_identifiers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ export class Identifiers {
static i18nEnd: o.ExternalReference = {name: 'ɵɵi18nEnd', moduleName: CORE};
static i18nApply: o.ExternalReference = {name: 'ɵɵi18nApply', moduleName: CORE};
static i18nPostprocess: o.ExternalReference = {name: 'ɵɵi18nPostprocess', moduleName: CORE};
static i18nLocalize: o.ExternalReference = {name: 'ɵɵi18nLocalize', moduleName: CORE};

static pipe: o.ExternalReference = {name: 'ɵɵpipe', moduleName: CORE};

Expand Down
1 change: 1 addition & 0 deletions packages/core/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ ng_module(
"//packages/core/src/interface",
"//packages/core/src/reflection",
"//packages/core/src/util",
"//packages/localize",
"@npm//rxjs",
"@npm//zone.js",
],
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/core_render3_private_export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ export {
ɵɵi18nApply,
ɵɵi18nPostprocess,
i18nConfigureLocalize as ɵi18nConfigureLocalize,
ɵɵi18nLocalize,
setLocaleId as ɵsetLocaleId,
setClassMetadata as ɵsetClassMetadata,
ɵɵresolveWindow,
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/render3/jit/environment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ export const angularCoreEnv: {[name: string]: Function} =
'ɵɵi18nEnd': r3.ɵɵi18nEnd,
'ɵɵi18nApply': r3.ɵɵi18nApply,
'ɵɵi18nPostprocess': r3.ɵɵi18nPostprocess,
'ɵɵi18nLocalize': r3.ɵɵi18nLocalize,
'ɵɵresolveWindow': r3.ɵɵresolveWindow,
'ɵɵresolveDocument': r3.ɵɵresolveDocument,
'ɵɵresolveBody': r3.ɵɵresolveBody,
Expand Down
5 changes: 0 additions & 5 deletions tools/public_api_guard/core/core.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -888,11 +888,6 @@ export declare function ɵɵi18nEnd(): void;

export declare function ɵɵi18nExp<T>(value: T): TsickleIssue1009;

/** @deprecated */
export declare function ɵɵi18nLocalize(input: string, placeholders?: {
[key: string]: string;
}): string;

export declare function ɵɵi18nPostprocess(message: string, replacements?: {
[key: string]: (string | string[]);
}): string;
Expand Down

0 comments on commit c024d89

Please sign in to comment.