Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return a value if the index does not exist #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanderlee
Copy link

If, for some reason, a non-existent value is set for the input, it will set undefined as the value for the input.
This change empties the value instead.
I don't know if this causes side-effects for other use cases, but it seems to work for me.

If, for some reason, a non-existent value is set for the input, it will set `undefined` as the value for the input.
This change empties the value instead.
I don't know if this causes side-effects for other use cases, but it seems to work for me.
@ryantheleach
Copy link
Contributor

ryantheleach commented Jul 24, 2017

I've seen the behaviour you described also, as well as when expecting an object, seeing a string instead.

e.g. I blank the input, press escape, and the sent value is the previous display value, rather then what I would expect: a empty / null value.

Even if it were expected behaviour to rollback, I would have expected to see the previous object, not the display string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants