Add Cube detector, Cube tracker #812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZdenekM
requested changes
Mar 21, 2023
| @@ -0,0 +1,5 @@ | |||
| color,x,y,z | |||
| @dataclass | ||
| class Cube(JsonSchemaMixin): | ||
| color: str | ||
| position: Position = field(default_factory=Position) |
ZdenekM
reviewed
Mar 21, 2023
ZdenekM
reviewed
Apr 3, 2023
ZdenekM
reviewed
Apr 20, 2023
| while _started: | ||
| t_start = time.monotonic() | ||
| _tracker.store_cubes(rest.call(rest.Method.GET, f"{URL_DETECTOR}/detect/all", list_return_type=Cube)) | ||
| time.sleep(1 - (time.monotonic() - t_start)) |
There was a problem hiding this comment.
So 1 Hz is the maximum speed? Or could it run faster, but you consider 1 Hz ok?
| $ref: WebApiError | ||
| """ | ||
| color = request.args.get("color", default=None) | ||
| return jsonify(_tracker.get_stored_cubes(color)), 200 |
There was a problem hiding this comment.
Does it return something in mock mode?
|
@Preclaa Also, before merging this, please squash your commits into one. Thanks! |
Preclaa
force-pushed
the
master
branch
6 times, most recently
from
dc9d1f5 to
f35f400
Compare
ZdenekM
approved these changes
May 11, 2023
Preclaa
force-pushed
the
master
branch
2 times, most recently
from
1e05e2d to
d581dea
Compare
Preclaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new modules - cube_detector and cube_tracker.
Cube detector detects colored cubes in image from Kinect.
Cube tracker periodically calls detector and stores positions of detected cubes.
New Object Type was added (CubeTracker) that can return Pose of nearest/farthest cube from given point.
Detector runs on port 5020, Tracker on port 5021. OT is integrated in
fit_demo.