Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entering names easier #197

Open
ZdenekM opened this issue Feb 12, 2021 · 5 comments
Open

Make entering names easier #197

ZdenekM opened this issue Feb 12, 2021 · 5 comments
Labels
enhancement New feature or request UX

Comments

@ZdenekM
Copy link
Member

ZdenekM commented Feb 12, 2021

As there are some restrictions for ObjectType type (which is actually class name in Python) and AP/object/etc. names (which are actually variables/properties), AREditor should provide more guidance when entering those:

  • Show example.
  • Disable disallowed characters on the keyboard.
  • Something else?

This is related to robofit/arcor2#443.

@ZdenekM ZdenekM added enhancement New feature or request UX labels Feb 12, 2021
@ZdenekM
Copy link
Member Author

ZdenekM commented Feb 12, 2021

It seems that Unity/Android does not have support for limiting available characters on the keyboard. Maybe custom validation for the input field might help here? See https://docs.unity3d.com/540/Documentation/ScriptReference/UI.InputField.OnValidateInput.html.

@ZdenekM
Copy link
Member Author

ZdenekM commented Feb 16, 2021

@Kapim ARServer behavior changed (the issue was closed). But I just got an idea, that it would be good if ARServer can provide a more specific error message on what is wrong with the type/name, maybe?

@Kapim
Copy link
Collaborator

Kapim commented Feb 16, 2021

I depends.. If there will be custom validator in editor, detailed error message should not be needed, because no wrong input will be passed to server (except for already used name). On the other hand, if there will be detailed message, no custom validation will be needed in AREditor or any other (future) GUI.

@ZdenekM
Copy link
Member Author

ZdenekM commented Feb 16, 2021

I think that the validator in the editor could be very very simple - probably just banning infeasible characters (if it is possible). The rest (e.g. checking if it is not a Python keyword) should be done by the server and the server should provide better error messages. Ok?

@ZdenekM
Copy link
Member Author

ZdenekM commented Feb 16, 2021

Better error messages: robofit/arcor2#450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX
Projects
None yet
Development

No branches or pull requests

2 participants