Motorola opcode 0x05 0x09 fix #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh interesting! this makes sense to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSBK opcode
0x05is used by Motorola systems to broadcast channel status information. This is incorrectly interpreted by Trunk Recorder as a "Unit To Unit Answer Request", and erroneously decodes and forwards the message as such. As this Motorola status message occurs several times a second, it has a significant impact on any plugin or downstream attempt to analyze system metadata.TSBK opcode
0x09is presently unused by Trunk Recorder, but also has a frequent Motorola-specific variant that should be logged separately. Known values are decoded as per Unitrunker display.This PR breaks out these two Motorola opcodes to prevent them from being decoded as a standard P25 message.