-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuGre friction model implementation #97
base: devel
Are you sure you want to change the base?
Conversation
Thanks @ale-git for the contribution 👍🏻 |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ale-git
Before merging this PR, we need to address several points.
Documentation
- The state equations is not correct.
- Missing details on
$g\left(v\right)$ . - It'd be appropriate to cite a paper on LuGre, e.g. DOI: 10.1109/mcs.2008.929425.
- Nothing is said about how to tune the LuGre params. This is fundamental to make it usable.
Implementation
- Especially when a dynamic is at stake, it's much better to resort to Simulink rather than MATLAB code. We already have an internal LuGre implementation in Simulink that I can refer you to1.
- Most of the time
$\sigma_1$ is related to$\sigma_0$ , as illustrated in the paper I cited above. - The model interface can be improved.
MATLAB Project
The project has to be fine-tuned, although this is the very last thing.
I propose to set up a meeting for this 🗓️
Footnotes
-
It looks like this in Physical signals but can be ported back to original Simulink signals very easily:
I committed the wrong README.md file, whose right version was deleted instead (fixed). |
Any update on this? |
Great! |
Hi @ale-git We still need to address the following important point:
|
The LuGre friction model has been implemented in SImulink, ready for automatic code generation.
The output code is included in icub-firmware to add sensorless torque estimation capabilities to the control boards.