Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not String.trim on cookies #81

Merged
merged 1 commit into from
Oct 29, 2024
Merged

do not String.trim on cookies #81

merged 1 commit into from
Oct 29, 2024

Conversation

hannesm
Copy link
Contributor

@hannesm hannesm commented Oct 29, 2024

this is more a question, whether it is fine to remove these String.trim? #67

@hannesm hannesm requested a review from PizieDust October 29, 2024 07:44
@PizieDust PizieDust removed their request for review October 29, 2024 07:53
@PizieDust PizieDust self-requested a review October 29, 2024 07:53
@PizieDust PizieDust added the enhancement New feature or request label Oct 29, 2024
PizieDust
PizieDust approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@PizieDust PizieDust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hannesm
I think this covers all the instances of String.trim project wide.

@PizieDust
Copy link
Collaborator

I'll go ahead and merge this

@PizieDust PizieDust merged commit 4856463 into main Oct 29, 2024
2 checks passed
@PizieDust PizieDust deleted the no-string-trim-cookie branch October 29, 2024 08:06
@PizieDust PizieDust added security Something potentially related to security and removed enhancement New feature or request labels Oct 29, 2024
@hannesm hannesm mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PizieDust PizieDust PizieDust approved these changes

Assignees

@hannesm hannesm

Labels
security Something potentially related to security
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesm @PizieDust