Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout functionality #87

Merged
merged 24 commits into from
Nov 5, 2024
Merged

Logout functionality #87

merged 24 commits into from
Nov 5, 2024

Conversation

PizieDust
Copy link
Collaborator

closes #86 #85

This PR adds buttons to close single sessions and also a logout button.

@PizieDust PizieDust requested a review from hannesm November 4, 2024 06:47
@PizieDust PizieDust self-assigned this Nov 4, 2024
@PizieDust PizieDust added the enhancement New feature or request label Nov 4, 2024
@PizieDust PizieDust marked this pull request as ready for review November 4, 2024 12:59
assets/main.js Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
PizieDust and others added 3 commits November 4, 2024 15:03
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
unikernel.ml Outdated Show resolved Hide resolved
Co-authored-by: Hannes Mehnert <[email protected]>
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
unikernel.ml Outdated Show resolved Hide resolved
user_account.ml Outdated Show resolved Hide resolved
@hannesm
Copy link
Contributor

hannesm commented Nov 4, 2024

Looks fine to me, only a few minor remarks above.

PizieDust and others added 6 commits November 4, 2024 15:10
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
Co-authored-by: Hannes Mehnert <[email protected]>
@PizieDust
Copy link
Collaborator Author

Thank you for the review @hannesm

@PizieDust PizieDust merged commit 52ba8d3 into main Nov 5, 2024
2 checks passed
@PizieDust PizieDust deleted the logout branch November 5, 2024 09:04
@hannesm
Copy link
Contributor

hannesm commented Nov 5, 2024

Thank you for the development :)

@hannesm hannesm mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

logout button
2 participants