feat(zbugs): opaque Timestamp type

apps/zbugs/schema.ts

@@ -2,20 +2,36 @@ import {
   createSchema,
   createTableSchema,
   definePermissions,
+  column,
   type ExpressionBuilder,
   type TableSchema,
   type Row,
 } from '@rocicorp/zero';
 import type {Condition} from 'zero-protocol/src/ast.js';
 
+export type Opaque<BaseType, BrandType = unknown> = BaseType & {
+  readonly [base]: BaseType;
+  readonly [brand]: BrandType;
+};
+
+declare const base: unique symbol;
+declare const brand: unique symbol;
+
+export type Timestamp = Opaque<number>;
+export function timestamp(n: number): Timestamp {
+  return n as Timestamp;
+}
+
+const {number, enumeration} = column;
+
 const userSchema = createTableSchema({
   tableName: 'user',
   columns: {
     id: 'string',
     login: 'string',
     name: 'string',
     avatar: 'string',
-    role: 'string',
+    role: enumeration<'crew' | 'user'>(),
   },
   primaryKey: 'id',
 });
@@ -27,8 +43,8 @@ const issueSchema = {
     shortID: {type: 'number', optional: true},
     title: 'string',
     open: 'boolean',
-    modified: 'number',
-    created: 'number',
+    modified: number<Timestamp>(),
+    created: number<Timestamp>(),
     creatorID: 'string',
     assigneeID: {type: 'string', optional: true},
     description: 'string',
@@ -81,7 +97,7 @@ const viewStateSchema = createTableSchema({
   columns: {
     issueID: 'string',
     userID: 'string',
-    viewed: 'number',
+    viewed: number<Timestamp>(),
   },
   primaryKey: ['userID', 'issueID'],
 });
@@ -148,7 +164,7 @@ const emojiSchema = {
     annotation: 'string',
     subjectID: 'string',
     creatorID: 'string',
-    created: 'number',
+    created: number<Timestamp>(),
   },
   primaryKey: 'id',
   relationships: {

apps/zbugs/src/components/emoji-panel.tsx

@@ -32,6 +32,7 @@ import {ButtonWithLoginCheck} from './button-with-login-check.js';
 import {type ButtonProps} from './button.js';
 import {EmojiPicker} from './emoji-picker.js';
 import {EmojiPill} from './emoji-pill.js';
+import {timestamp} from '../../schema.js';
 
 const loginMessage = 'You need to be logged in to modify emoji reactions.';
 
@@ -65,7 +66,7 @@ export const EmojiPanel = memo(
             annotation,
             subjectID,
             creatorID: z.userID,
-            created: Date.now(),
+            created: timestamp(Date.now()),
           });
         },
         [subjectID, z],

apps/zbugs/src/emoji-utils.test.ts

@@ -2,11 +2,12 @@ import type {Writable} from 'shared/src/writable.js';
 import {expect, test} from 'vitest';
 import type {Emoji} from './emoji-utils.js';
 import {formatEmojiCreatorList, formatEmojiTooltipText} from './emoji-utils.js';
+import {timestamp} from '../schema.js';
 
 function makeEmoji(userID: string, login: string): Emoji {
   return {
     id: 'id',
-    created: Date.now(),
+    created: timestamp(Date.now()),
     creatorID: userID,
     annotation: 'waves hand',
     subjectID: 'subject-id',
@@ -16,7 +17,7 @@ function makeEmoji(userID: string, login: string): Emoji {
       login,
       avatar: 'avatar',
       name: 'James Holden',
-      role: 'admin',
+      role: 'crew',
     },
   };
 }

apps/zbugs/src/pages/issue/issue-composer.tsx

@@ -4,6 +4,7 @@ import {Button} from '../../components/button.js';
 import {Modal, ModalActions, ModalBody} from '../../components/modal.js';
 import {useZero} from '../../hooks/use-zero.js';
 import {isCtrlEnter} from './is-ctrl-enter.js';
+import {timestamp} from '../../../schema.js';
 
 interface Props {
   /** If id is defined the issue created by the composer. */
@@ -52,9 +53,9 @@ export default function IssueComposer({isOpen, onDismiss}: Props) {
       id,
       title,
       description: description ?? '',
-      created: Date.now(),
+      created: timestamp(Date.now()),
       creatorID: z.userID,
-      modified: Date.now(),
+      modified: timestamp(Date.now()),
       open: true,
       visibility: 'public',
     });

apps/zbugs/src/pages/issue/issue-page.tsx

@@ -19,7 +19,12 @@ import {assert} from 'shared/src/asserts.js';
 import {useParams} from 'wouter';
 import {navigate, useHistoryState} from 'wouter/use-browser-location';
 import {must} from '../../../../../packages/shared/src/must.js';
-import type {CommentRow, IssueRow, Schema} from '../../../schema.js';
+import {
+  timestamp,
+  type CommentRow,
+  type IssueRow,
+  type Schema,
+} from '../../../schema.js';
 import statusClosed from '../../assets/icons/issue-closed.svg';
 import statusOpen from '../../assets/icons/issue-open.svg';
 import {Button} from '../../components/button.js';
@@ -87,7 +92,7 @@ export function IssuePage() {
         z.mutate.viewState.upsert({
           issueID: issue.id,
           userID: z.userID,
-          viewed: Date.now(),
+          viewed: timestamp(Date.now()),
         });
       }, 1000);
       return () => clearTimeout(handle);