tests

rocicorp · Dec 28, 2024 · c90b4f0 · c90b4f0
1 parent 776a685
commit c90b4f0
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 2 deletions.
diff --git a/packages/zero-solid/src/solid-view.test.ts b/packages/zero-solid/src/solid-view.test.ts
@@ -1,4 +1,5 @@
 import {expect, test} from 'vitest';
+import {resolver} from '@rocicorp/resolver';
 import {MemorySource} from '../../zql/src/ivm/memory-source.js';
 import {SolidView, solidViewFactory} from './solid-view.js';
 import type {Query, Smash} from '../../zql/src/query/query.js';
@@ -24,6 +25,8 @@ test('basics', () => {
     {a: 2, b: 'b'},
   ]);
 
+  expect(view.resultType).toEqual('complete');
+
   ms.push({row: {a: 3, b: 'c'}, type: 'add'});
 
   expect(view.data).toEqual([
@@ -71,6 +74,39 @@ test('single-format', () => {
   expect(view.data).toEqual(undefined);
 });
 
+test('queryComplete promise', async () => {
+  const ms = new MemorySource(
+    'table',
+    {a: {type: 'number'}, b: {type: 'string'}},
+    ['a'],
+  );
+  ms.push({row: {a: 1, b: 'a'}, type: 'add'});
+  ms.push({row: {a: 2, b: 'b'}, type: 'add'});
+
+  const queryCompleteResolver = resolver<true>();
+
+  const view = new SolidView(
+    ms.connect([
+      ['b', 'asc'],
+      ['a', 'asc'],
+    ]),
+    undefined,
+    undefined,
+    queryCompleteResolver.promise,
+  );
+
+  expect(view.data).toEqual([
+    {a: 1, b: 'a'},
+    {a: 2, b: 'b'},
+  ]);
+
+  expect(view.resultType).toEqual('unknown');
+
+  queryCompleteResolver.resolve(true);
+  await 1;
+  expect(view.resultType).toEqual('complete');
+});
+
 type TestSchema = {
   tableName: 'test';
   columns: {
@@ -114,6 +150,8 @@ test('factory', () => {
     ]),
     {singular: false, relationships: {}},
     onDestroy,
+    () => undefined,
+    true,
   );
   expect(view).toBeDefined();
   expect(onDestroyCalled).false;

diff --git a/packages/zero-solid/src/solid-view.ts b/packages/zero-solid/src/solid-view.ts
@@ -32,7 +32,7 @@ export class SolidView<V extends View> implements Output {
     input: Input,
     format: Format = {singular: false, relationships: {}},
     onDestroy: () => void = () => {},
-    queryComplete: true | Promise<true>,
+    queryComplete: true | Promise<true> = true,
   ) {
     this.#input = input;
     this.#format = format;
@@ -41,7 +41,7 @@ export class SolidView<V extends View> implements Output {
       '': format.singular ? undefined : [],
     });
     [this.#resultTypeStore, this.#setResultType] = createStore({
-      resultType: queryComplete ? 'complete' : 'unknown',
+      resultType: queryComplete === true ? 'complete' : 'unknown',
     });
     input.setOutput(this);