feat(zbugs): useWatchQuery

[arv]

This is WIP but I want some feedback.

This creates a new hook that takes a callback that gets called with the changes that come out at the end of the pipeline.

This is based on the ideas I had last week (or the week before that?) when I first worked on adding the emoji change callbacks.

Usage:

useWatchQuery(z.query.comment.where('issueID', id), change => {
  if (change.type === 'add') {
    console.log(change.row, 'was added');
  } else if (change.type === 'remove') {
    console.log(change.row, 'was removed');
  }
});

Things that are not obvious/clean.

• Name of the hook?
• The implementation waits for the transaction end but this information is lost in the callback. We could call the callback with an array of all the changes instead.
• What to do about child changes since at this level there is no memory of the previous children?
• Should the hook have an option to also be called for non complete results or maybe add that info to the change objects?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
replicache-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 3:17pm
zbugs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 3:17pm

[tantaman]

• Name of the hook?

useDiffQuery ?

• The implementation waits for the transaction end but this information is lost in the callback. We could call the callback with an array of all the changes instead.

Array of all the changes would make sense but I think each change has to be processed as it is received if the callback is consuming relationships.

• What to do about child changes since at this level there is no memory of the previous children?

I don't follow.

[arv]

Array of all the changes would make sense but I think each change has to be processed as it is received if the callback is consuming relationships.

Now I don't follow :-)

What to do about child changes since at this level there is no memory of the previous children?

I don't follow.

At this point in time the child relationships are ignored. What should really happen is that I should use the applyChange logic (which needs some fixes) so that the relationships gets filled in.

---

This is pretty incomplete and that is why I decided to put it in zbugs and not in zero-client.

[arv]

I wanted to define a new type to prevent tight coupling with the ivm Change type

[arv]

These do not contain the relationships

[grgbkr]

Hmmm I wonder if we can reasonably push this down a layer so that it can be used in non-React environments like Cloudflare-DO, NodeJS, vanilla JS.

[aboodman]

Your perlow contact in the channel had an amazing idea: to propagate mutation name and args to client and drive effects off that. There was a long thread. a (phone)

…

On Sat, Dec 21, 2024 at 8:35 AM Greg Baker ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In apps/zbugs/src/hooks/use-watch-query.tsx <#3307 (comment)>: > + + flush() { + if (!this.#queryComplete) { + return; + } + + for (const change of this.#pendingChanges) { + for (const cb of this.#subscribers) { + cb(toChange(change)); + } + } + this.#pendingChanges = []; + } +} + +function changeViewFactory< Hmmm I wonder if we can reasonably push this down a layer so that it can be used in non-React environments like Cloudflare-DO, NodeJS, vanilla JS. — Reply to this email directly, view it on GitHub <#3307 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATUBDE5IWMJNVWCGJCZA32GWYHRAVCNFSM6AAAAABTSGDWCSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJYHAYDINBRHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>