Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zero-vue): Vue bindings for Zero #3422

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

markusgeert
Copy link

This PR adds a useQuery composable in order to use Zero in the context of Vue. The bindings are heavily based on the existing Solid ones, but so far they seem to work correctly.

A sample project showcasing the client in a Vue project, based on hello-zero-solid is available here.

Copy link

vercel bot commented Dec 19, 2024

@markusgeert is attempting to deploy a commit to the Rocicorp Team on Vercel.

A member of the Team first needs to authorize it.

@arv arv requested review from arv and grgbkr December 19, 2024 20:06
@arv
Copy link
Contributor

arv commented Dec 19, 2024

Very cool.

I think this looks good but we haven't updated the Solid bindings to match the React bindings with the resultType part. Maybe it makes sense to do this in this PR or in a followup?

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replicache-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:11pm
zbugs ✅ Ready (Inspect) Visit Preview Dec 19, 2024 8:11pm

@markusgeert
Copy link
Author

I think this looks good but we haven't updated the Solid bindings to match the React bindings with the resultType part. Maybe it makes sense to do this in this PR or in a followup?

I brought the return of useQuery in line with the react one, probably nice to have that immediately.

One minor thing is that the QueryResultDetails type is now duplicated between zero-vue and zero-react, since I didn't really know where to put it otherwise.

@arv
Copy link
Contributor

arv commented Dec 31, 2024

Thank you.

Once things settle a bit after the holidays I would like to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants