Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple more Windows compat measures #3452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

A couple more Windows compat measures #3452

wants to merge 2 commits into from

Conversation

cbnsndwch
Copy link
Contributor

  • handle windows path separators in relative path to schema file
  • fix import path format for child worker forks

Addresses the comments in #3448

@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024

@cbnsndwch is attempting to deploy a commit to the Rocicorp Team on Vercel.

A member of the Team first needs to authorize it.

@cbnsndwch cbnsndwch mentioned this pull request Dec 24, 2024
Merged
cbnsndwch referenced this pull request Dec 25, 2024
@tantaman
feat(zero-cache): make forking processes work on windows
576f796
@tantaman
Copy link
Contributor

Is there anything left for windows support given #3448 was merged?

@tantaman
Copy link
Contributor

tantaman commented Jan 2, 2025

Looks like silent: true is the last problem. I'm going to investigate correctly handling child process output rather than relying on silent: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbnsndwch @tantaman