feat(zero): namespace custom mutators to the table they impact

[tantaman]

Rather than having all mutators at the top level, they'll need to be namespaced.

Example:

const mutators = {
    issue: {
      setTitle: (tx, id: string, title: string) => {
        tx.mutate.issue.update({id, title});
      },
    },
   notATableName: { doThing: () => {} }
};

The namespace is not required to match a table name but tables names are provided to intellisense at this callsite.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
replicache-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 29, 2025 7:58pm
zbugs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 29, 2025 7:58pm

[github-actions]

Bencher Report

Branch	mlaw/namespace-mutators
Testbed	localhost

Click to view all benchmark results

Benchmark	File Size	Benchmark Result kilobytes (KB) (Result Δ%)	Upper Boundary kilobytes (KB) (Limit %)
zero-package.tgz	📈 view plot 🚷 view threshold	919.04 (+0.02%)	937.21 (98.06%)
zero.js	📈 view plot 🚷 view threshold	171.55 (0.00%)	174.99 (98.04%)
zero.js.br	📈 view plot 🚷 view threshold	47.80 (0.00%)	48.76 (98.04%)

🐰 View full continuous benchmarking report in Bencher

[github-actions]

Bencher Report

Branch	mlaw/namespace-mutators
Testbed	localhost

Click to view all benchmark results

Benchmark	Throughput	Benchmark Result operations / second (ops/s) (Result Δ%)	Lower Boundary operations / second (ops/s) (Limit %)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)	📈 view plot 🚷 view threshold	70.15 (-2.97%)	69.58 (99.19%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)	📈 view plot 🚷 view threshold	91.98 (-2.71%)	91.09 (99.03%)

🐰 View full continuous benchmarking report in Bencher

[aboodman]

Not sure how I feel about prompting the table names. I'll try it out.

…

On Wed, Jan 29, 2025 at 10:04 AM Matt Wonlaw ***@***.***> wrote: Merged #3648 <#3648> into main. — Reply to this email directly, view it on GitHub <#3648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATUBCEF4NSNWO54SCN7H32NEX5HAVCNFSM6AAAAABWDTDSICVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGEYTGNJXGE2TENQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[aboodman]

(because people might misunderstand that they can only use those names) On Wed, Jan 29, 2025 at 10:13 AM Aaron Boodman ***@***.***> wrote:

…

Not sure how I feel about prompting the table names. I'll try it out. On Wed, Jan 29, 2025 at 10:04 AM Matt Wonlaw ***@***.***> wrote: > Merged #3648 <#3648> into main. > > — > Reply to this email directly, view it on GitHub > <#3648 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAATUBCEF4NSNWO54SCN7H32NEX5HAVCNFSM6AAAAABWDTDSICVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGEYTGNJXGE2TENQ> > . > You are receiving this because you were assigned.Message ID: > ***@***.***> >

[tantaman]

(because people might misunderstand that they can only use those names)

good point.

[aboodman]

I don't know how hard it is but I thought people might enjoy creating whatever hierarchy they want there? Like having more than two levels? You know cuz I know how much you love TS wrangling.

…

On Wed, Jan 29, 2025 at 10:15 AM Matt Wonlaw ***@***.***> wrote: (because people might misunderstand that they can only use those names) good point. — Reply to this email directly, view it on GitHub <#3648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATUBBUZOZYPLTCOYTEYEL2NEZGFAVCNFSM6AAAAABWDTDSICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSG42DONBRGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[tantaman]

You know cuz I know how much you love TS wrangling.

I'm honestly getting tired of it 😅. I was more than happy when arv took on the "type heirarchy too deep" bug

I don't know how hard it is but I thought people might enjoy creating whatever hierarchy they want there?

Mind if I circle back to this after we have custom mutators w/o reads working end to end?

[aboodman]

I don't know how hard it is but I thought people might enjoy creating

whatever hierarchy they want there? Mind if I circle back to this after we have custom mutators w/o reads working end to end?

Not at all.

…

— Reply to this email directly, view it on GitHub <#3648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATUBHM5T76BZYYIZWGYLL2NE3VDAVCNFSM6AAAAABWDTDSICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSG44DSNBVGQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[arv]

LGTM

[arv]

Can you add a test where there isn't a "namespace" too?

const mutators = {
   setTitle: (tx, id: string, title: string) => {
     tx.mutate.issue.update({id, title});
   },  
};