fix: View changed not propagating #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arv
commented
Mar 15, 2024
src/zql/ivm/view/tree-view.ts
Outdated
| @@ -65,7 +65,7 @@ class AbstractTreeView<T> extends AbstractView<T, T[]> { | |||
|
|
|||
| let newData = this.#data; | |||
| for (const c of collections) { | |||
| [changed, newData] = this.#sink(c, newData) || changed; | |||
| [changed, newData] = this.#sink(c, newData, changed); | |||
There was a problem hiding this comment.
I was stepping through the code and found this strange code.
this.#sink never returns a falsey value.
It seems to me based on looking at the code that changed could go from true to false if some later collection does not change anything.
tantaman
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.