remove code not strictly required for ZQL, update comments [1] #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantaman
changed the title
arv
reviewed
Mar 29, 2024
tantaman
changed the title
tantaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue. We never actually build up a queue of values in this implementation. Everything is batched into a single multiset each transaction due to ourqueue,notify,runstaging.PersistentTreeView(we only need a mutable tree for ZQL. For now anyway..)AbstractTreeView(no longer have two different tree views since we removed the persistent one)IDifferenceStream(ZQL only has a single implementation)PassThroughOperator(ZQL doesn't need to temporarily detach pipelines)StatelessSource(ZQL always queries history)GroupBy has some changes to aggregation that will let us:
AbstractViewPrimitiveViewThe
queue,notify,run,notifyCommittedpattern still exists. It doesn't seem that difficult to grok once I looked at it again to consider removing it.