-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: allow EntityQuery to select from many tables #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantaman
changed the title
join types: allow EntityQuery to select from many tables
types: allow EntityQuery to select from many tables
Apr 5, 2024
tantaman
force-pushed
the
mlaw/from-set
branch
2 times, most recently
from
April 8, 2024 12:06
3a6f6c2
to
70ac0dd
Compare
Merged with @arv 's latest changes around complex where conditions. |
tantaman
commented
Apr 8, 2024
tantaman
commented
Apr 8, 2024
arv
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E.g., since we'll have join and join introduces different tables into a query: ```ts s.select('foo.*', 'bar.*') ```
tantaman
added a commit
to rocicorp/mono
that referenced
this pull request
Apr 9, 2024
identical to: rocicorp/rails#62
tantaman
added a commit
to rocicorp/mono
that referenced
this pull request
Apr 9, 2024
identical to: rocicorp/rails#62
tantaman
added a commit
to rocicorp/mono
that referenced
this pull request
Apr 9, 2024
identical to: rocicorp/rails#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
join
will bring in more tables that can be selected against. Thus,EntityQuery.select
needs to be able pull from more than a single schema.To do that,
EntityQuery
now takes aFromSet
rather thanEntitySchema
.join
requires us to support aliasing ambiguous columns so this adds that as well.