Revert "Remove diff-server from the JS SDK (#120)"

This reverts commit 409d4ee.

.github/workflows/perf.js.yml

@@ -17,6 +17,7 @@ jobs:
 
       - run: npm ci
       - run: npm run build --if-present
+      - run: git restore --quiet bin/diff-server
 
       # Run benchmark and stores the output to a file
       - name: Run benchmark

HACKING.md

@@ -1,6 +1,6 @@
 # Getting binary dependencies
 
-`npm install` automatically downloads the correct version of the wasm bundle.
+`npm install` automatically downloads the correct version of the wasm bundle and `diff-server`.
 
 # Building against a dev version of repc
 

bin/diff-server

@@ -0,0 +1,3 @@
+#!/usr/bin/env node
+console.error('diff-server: Failed to install correctly');
+process.exit(1);

package.json

@@ -13,10 +13,14 @@
     "build": "tsc && rm -rf out/wasm && mkdir out/wasm && cp -R src/wasm/* out/wasm",
     "build:watch": "tsc --watch",
     "build:cjs": "tsc --outDir out.cjs --module CommonJS && rm -rf out.cjs/wasm && mkdir out.cjs/wasm && cp -R src/wasm/* out.cjs/wasm",
+    "start:diff-server": "bin/diff-server --db=/tmp/diffs serve",
     "postinstall": "rm -f node_modules/fetch-mock/esm/client.d.ts && tool/get-deps.sh",
-    "prepublishOnly": "npm run lint && npm run test && rm -rf out && npm run build && rm -rf out.cjs && npm run build:cjs",
+    "prepublishOnly": "tool/validate-binaries-for-publish.js && npm run lint && npm run test && rm -rf out && npm run build && rm -rf out.cjs && npm run build:cjs",
     "perf": "node perf/runner.mjs"
   },
+  "bin": {
+    "diff-server": "bin/diff-server"
+  },
   "devDependencies": {
     "@esm-bundle/chai": "^4.1.5",
     "@types/mocha": "^8.0.3",

tool/get-deps.sh

@@ -17,8 +17,14 @@ REPC_VERSION='v0.9.0'
     exit
   fi
 
+  # Diff server is a public interface. We *do* maintain backward compat.
+  # We download the latest release.
+  echo "Fetching diff-server..."
+  URL="https://github.com/rocicorp/diff-server/releases/latest/download/diffs-$PLATFORM"
+  curl -L -f $URL > bin/diff-server
+  chmod u+x bin/diff-server
+
   echo "Fetching repc..."
-  mkdir -p bin
   URL="https://github.com/rocicorp/repc/releases/download/$REPC_VERSION/repc.zip"
   curl -L -f $URL > bin/repc.zip
   cd bin

tool/validate-binaries-for-publish.js

@@ -0,0 +1,27 @@
+#!/usr/bin/env node
+'use strict';
+
+// This file is used to ensure that we are not trying to publish the downloaded
+// binaries.
+
+const {existsSync, statSync} = require('fs');
+const {join} = require('path');
+
+function validateFile(name) {
+  const p = join(__dirname, '..', 'bin', name);
+  if (!existsSync(p)) {
+    console.error(`${name} does not exist`);
+    process.exit(1);
+  }
+
+  // If it exists, make sure that this is not the compiled binary.
+  const stat = statSync(p);
+  if (stat.size > 10000) {
+    console.error(
+      `${name} looks too large. Has it been replaced by the binary?`,
+    );
+    process.exit(1);
+  }
+}
+
+validateFile('diff-server');