fix: Navigo kept adding listeners (#19)

Anytime the URL changed we added a new listener. This lead to confusion.
rocicorp · Mar 19, 2024 · af3f055 · af3f055
1 parent 5e402ab
commit af3f055
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/client/src/app.tsx b/client/src/app.tsx
@@ -25,14 +25,18 @@ const App = ({
   const [listID, setListID] = useState('');
   const [showingShare, setShowingShare] = useState(false);
 
-  router.on('/list/:listID', match => {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    const {data} = match!;
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    const {listID} = data!;
-    setListID(listID);
+  useEffect(() => {
+    router.on('/list/:listID', match => {
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+      const {data} = match!;
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+      const {listID} = data!;
+      setListID(listID);
+    });
+    return () => {
+      router.off('/list/:listID');
+    };
   });
-
   useEffect(() => {
     router.resolve();
   }, []);