-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend python package features #113
Conversation
bb1974b
to
4e3f401
Compare
This seems to work for me, thanks! Any opinions against switching to |
I would prefer not to, for now af least. I'm in the middle of fixing a lot of things (haven't use the python stuff in a while) and I would have to stop to retest and reassess. Is there a good reason to use pip for that? That's not what I've seen other build tools do. |
After a quick search it seems we get more control over what happens with setup.py so that's better to integrate. Also pip will try to manage dependencies and I want autoproj to be the tool doing that. For a user, using pip sounds like a step forward but for a tool I would stick to setup.py |
4e3f401
to
dd95f9c
Compare
You can avoid having pip download dependencies when you pass the Direct invocations of
Related issue: #108 This workflow will probably keep working for some time. And if users stick to old versions of pip and setuptools (or rather maintain compatibility with the legacy build system), potentially even longer. Most users will probably want to have their packages pip-installable anyways, so they potentially need to maintain their dependencies in several places. But then again, maybe they could also add their packages as pip osdeps and/or via a custom package index (directory). For reference:
But I agree, this is a bigger topic. And I'm happy to see, that this PR seems to fix the immediate issue #106. |
dd95f9c
to
7afd0a3
Compare
I have removed the pytest test utility and left only the fixes for #106 and rock-core/autoproj#313 |
Fixes #106 and rock-core/autoproj#313
@moooeeeep Could you please test?