Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add .NET9 on 24.10 #697

Merged
merged 2 commits into from
Jan 9, 2025
Merged

feat: add .NET9 on 24.10 #697

merged 2 commits into from
Jan 9, 2025

Conversation

zhijie-yang
Copy link

Changes proposed in this pull request:

  • Add support for .NET 9 on 24.10

@zhijie-yang zhijie-yang requested review from cjdcordeiro and a team January 8, 2025 10:36
cjdcordeiro
cjdcordeiro requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the top-level yaml files also need to be modified for the central CI to pick it up

cjdcordeiro
cjdcordeiro approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm my previous comment. I see the yaml files are being renamed in this PR. It LGTM thanks

rebornplusplus
rebornplusplus approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the nitpick below.

dotnet-aspnet/Dockerfile.24.10 Outdated Show resolved Hide resolved
dotnet-runtime/Dockerfile.24.10 Outdated Show resolved Hide resolved
@zhijie-yang @rebornplusplus
chore: apply suggestions from code review
62a2b27 
Co-authored-by: Rafid Bin Mostofa <[email protected]>
Signed-off-by: zhijie-yang <[email protected]>
@zhijie-yang zhijie-yang self-assigned this Jan 9, 2025
@rebornplusplus rebornplusplus merged commit 64804d0 into channels/9.0/stable Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornplusplus rebornplusplus rebornplusplus approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees

@zhijie-yang zhijie-yang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhijie-yang @cjdcordeiro @rebornplusplus