Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beryx jlink plugin support for gradle #12

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

vpa1977
Copy link
Collaborator

@vpa1977 vpa1977 commented Oct 7, 2024

Add support for Beryx JLink plugin:
https://github.com/beryx/badass-jlink-plugin

Changes:

  • use task output instead of artifacts
  • detect beryx plugin (jlink task)
  • use jlink task output if present to:
    • copy image inside rock
    • detect launcher
    • configure rock services

This PR depends on merging previous ones (will require rebase)

  • Have you signed the CLA?

@vpa1977 vpa1977 marked this pull request as ready for review October 8, 2024 01:26
@vpa1977 vpa1977 requested a review from pushkarnk October 8, 2024 01:39
Copy link
Collaborator

@pushkarnk pushkarnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vpa1977 vpa1977 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into rockcrafters:main with commit 25f7023 Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants