Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor preparing to implement maven plugin #5

Merged
merged 8 commits into from
Oct 6, 2024

Conversation

vpa1977
Copy link
Collaborator

@vpa1977 vpa1977 commented Oct 4, 2024

  • Use Java version 8

  • Extract RockProjectSettings to pass build system project data

  • Run formatter

  • Use common configuration for group and version

  • Have you signed the CLA?


apply common group and version for all projects.
@vpa1977 vpa1977 force-pushed the rename-common-library branch 3 times, most recently from d3f40ad to 9deee35 Compare October 4, 2024 10:12
@vpa1977 vpa1977 force-pushed the rename-common-library branch from 9deee35 to f90614f Compare October 4, 2024 10:50
@vpa1977 vpa1977 requested a review from pushkarnk October 4, 2024 11:10
@vpa1977 vpa1977 added this pull request to the merge queue Oct 6, 2024
Merged via the queue into rockcrafters:main with commit 50f5d5a Oct 6, 2024
2 checks passed
@pushkarnk pushkarnk mentioned this pull request Oct 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants