Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 stake/deposit warning #632

Merged
merged 5 commits into from
Sep 4, 2024
Merged

V1 stake/deposit warning #632

merged 5 commits into from
Sep 4, 2024

Conversation

thomaspanf
Copy link
Member

@thomaspanf thomaspanf commented Aug 26, 2024

Reference to hotfix: Prevent staking and depositing until voting power is initialised

Adds this warning to rp node stake-rpl and rp node deposit

Your voting power hasn't been initialized yet. Please visit https://docs.rocketpool.net/guides/houston/participate#initializing-voting to learn more.
NOTE: by staking RPL, your node will automatically initialize voting power to itself. If you would like to delegate your on-chain voting power, you should run the command `rocketpool pdao initialize-voting` before staking RPL.
Would you like to continue? [y/n]
n

stake-rpl.go and deposit.go only displays this warning after 1.3.1 hotfix has been deployed. See: rocket-pool/rocketpool-go#30

Copy link
Contributor

@jshufro jshufro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deduplicate the identical code in deposit.go/stake-rpl.go

@0xfornax
Copy link
Member

0xfornax commented Sep 3, 2024

We can bump the rocketpool-go version now.

@0xfornax 0xfornax merged commit ed5292a into master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants