Rename ReadManifestLiveFiles -> FindLiveFilesFromLocalManifest

rockset · Sep 25, 2023 · 795f08b · 795f08b
1 parent 504e55d
commit 795f08b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/cloud/cloud_file_system_impl.cc b/cloud/cloud_file_system_impl.cc
@@ -2304,7 +2304,7 @@ IOStatus CloudFileSystemImpl::FindAllLiveFiles(
   return IOStatus::OK();
 }
 
-IOStatus CloudFileSystemImpl::ReadManifestLiveFiles(
+IOStatus CloudFileSystemImpl::FindLiveFilesFromLocalManifest(
     const std::string& manifest_file,
     std::vector<std::string>* live_sst_files) {
   std::unique_ptr<LocalManifestReader> extractor(

diff --git a/cloud/cloud_file_system_impl.h b/cloud/cloud_file_system_impl.h
@@ -159,7 +159,7 @@ class CloudFileSystemImpl : public CloudFileSystem {
                             std::vector<std::string>* live_sst_files,
                             std::string* manifest_file) override;
 
-  IOStatus ReadManifestLiveFiles(
+  IOStatus FindLiveFilesFromLocalManifest(
       const std::string& manifest_file,
       std::vector<std::string>* live_sst_files) override;
 

diff --git a/cloud/cloud_file_system_wrapper.h b/cloud/cloud_file_system_wrapper.h
@@ -248,7 +248,9 @@ class MockCloudFileSystem : public CloudFileSystem {
     return notsup_;
   }
 
-  IOStatus ReadManifestLiveFiles(const std::string& /* manifest_file */, std::vector<std::string>* /* live_sst_files */) override {
+  IOStatus FindLiveFilesFromLocalManifest(
+      const std::string& /* manifest_file */,
+      std::vector<std::string>* /* live_sst_files */) override {
     return notsup_;
   }
 

diff --git a/include/rocksdb/cloud/cloud_file_system.h b/include/rocksdb/cloud/cloud_file_system.h
@@ -637,7 +637,7 @@ class CloudFileSystem : public FileSystem {
   // references. Unlike FindAllLiveFiles, this method doesn't resolve the
   // manifest name from the cloud manifest and also doesn't pull the manifest
   // (i.e., it needs to be present locally).
-  virtual IOStatus ReadManifestLiveFiles(
+  virtual IOStatus FindLiveFilesFromLocalManifest(
       const std::string& manifest_file,
       std::vector<std::string>* live_sst_files) = 0;