Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose AWS endpointOverride option #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jecaro
Copy link

@jecaro jecaro commented Sep 27, 2024

This allows you to connect to a local minio server. This is based on this idea.

It adds a new option endpoint_override which is given to the S3 client. I wrapped it up in a new struct AwsOptions like in the original idea as it opens the door to additional useful settings such as proxy, scheme, etc... Let me know if you want me to add some of them as part of this PR.

As for me, this is good enough to connect to a local minio server:

  • I set the bucket prefix to "" (It currently defaults to "rockset." and AWS will try to resolve the bucket name as a domain in this case)
  • I set endpoint_override to "http://127.0.0.1:9000"

This allows to connect to a local minio server, using for example:
"http://127.0.0.1:9000"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants