Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nofussvendor sort local replaces #201

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephtate
Copy link

Better interactivity with go mod tidy by sorting the replaces.

- Sorts sync-replace entries alphabetically
  - More compatible with go mod tidy
- Removes obsolete ioutil calls
- sorts imports: prettier
@resf-prow
Copy link
Contributor

resf-prow bot commented Nov 12, 2024

Hi @josephtate. Thanks for your PR.

I'm waiting for a rocky-linux member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mstg
Copy link
Member

mstg commented Nov 13, 2024

/approve
/lgtm

@resf-prow resf-prow bot assigned mstg Nov 13, 2024
@resf-prow resf-prow bot added the lgtm label Nov 13, 2024
@resf-prow
Copy link
Contributor

resf-prow bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephtate, mstg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@resf-prow resf-prow bot added the approved label Nov 13, 2024
@resf-prow
Copy link
Contributor

resf-prow bot commented Nov 13, 2024

@josephtate: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-peridot-unit-test b9b5212 link true /test pull-peridot-unit-test
pull-peridot-non-manual-build b9b5212 link true /test pull-peridot-non-manual-build
pull-peridot-build-impacted-frontend b9b5212 link true /test pull-peridot-build-impacted-frontend
pull-peridot-gofmt-check b9b5212 link true /test pull-peridot-gofmt-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mstg
Copy link
Member

mstg commented Nov 13, 2024

Looks like the CI base image has "expired. This is a known Bazel issue, I'll get that fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants