Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Expose double return bug #458

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: Expose double return bug #458

wants to merge 1 commit into from

Conversation

Et7f3
Copy link

@Et7f3 Et7f3 commented May 31, 2023

This PR only add test.

@Et7f3 Et7f3 mentioned this pull request May 31, 2023
Open
rocky
rocky requested changes May 31, 2023
View reviewed changes
Copy link
Owner

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we cannot commit something that breaks things without the fix.
The source code for this should appear in test/simple_source somewhere.

@Et7f3
Copy link
Author

Et7f3 commented May 31, 2023

Obviously we cannot commit something that breaks things without the fix

I put in draft to avoid mistake. Other repo propose this so a dev could directly push to that branch and get the CI green.

The source code for this should appear in test/simple_source somewhere.

Thanks I didn't saw it.

@rocky rocky force-pushed the master branch 7 times, most recently from b7eae4f to 29edaae Compare March 16, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocky rocky rocky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Et7f3 @rocky