Partial install script #236
Conversation
|
There was a problem with regex file names like |
|
This time I tested the whole thing. Turns out there was still an error, and I fixed it. Now it can be merged. |
|
Thanks. Nitpicking a bit, but why not having a function in this script and using this function for the recursive part (instead of calling the script again). It seems to me this is what you proposed initially. |
Yes indeed. It was problematic with regex profiles for some reason. The only challenge in this was really how sometimes you call other profiles using regex. I could get it to work with this, and not with the funtion. Maybe it is possible to find a workaround there too but I don't see why it would be necessary because this works already. |
…armor.d into monsieuremre-partial-install * 'partial-install' of https://github.com/monsieuremre/apparmor.d: dont try abstractions names even more fix fix partial install partial.sh
|
Can you have test e047da9. I get the same result than without the function. It may no be perfect still. |
roddhjav
force-pushed
the
main
branch
2 times, most recently
from
7e0f337 to
d3751d3
Compare
|
Closing, as more integration is required anyway a full implementation would most likely have to be integrated within the prebuild system. |
Please do not merge just yet. I got rid of the function and make the functionality work in a standalone script. It probably just works but it needs testing. After testing we can merge.