app: ghProfile: rename action type names

rodmax · Nov 10, 2019 · 2641a76 · 2641a76
1 parent 1311075
commit 2641a76
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -31,8 +31,8 @@ The main purpose of this project is to study web applications development based
     - Store
         - [x] Redux
         - [x] [type safety with redux](https://medium.com/@dhruvrajvanshi/some-tips-on-type-safety-with-redux-98588a85604c):
-        - [x] [actions naming](https://itnext.io/namespacing-redux-action-type-constant-values-90b932eea43f)
-        the best approach in terms of minimal boilerplate|strong typing|no unneeded abstractions/libs in my opinion
+        - [x] [actions naming](https://itnext.io/namespacing-redux-action-type-constant-values-90b932eea43f) -
+        my current choice how to name action types
     - [ ] Effects/async flow: RxJs(rxjs/observable)
     - [ ] Router: router5
     - API client (rxjs based?)

diff --git a/docs/bundle.js b/docs/bundle.js
diff --git a/docs/bundle.js.map b/docs/bundle.js.map
diff --git a/src/app/modules/github-profile/state/github-profile.actions.ts b/src/app/modules/github-profile/state/github-profile.actions.ts
@@ -2,11 +2,11 @@ import { GithubUserDto } from '../api/github-profile-api.typings'
 import { rdxActionCreator } from '../../../shared/redux/redux-tools'
 
 export const ghProfileActions = {
-    fetchRequested: rdxActionCreator('@ghProfile.fetchRequested').withPayload<{
+    fetchRequested: rdxActionCreator('@gh-profile/fetch-requested').withPayload<{
         username: string
     }>(),
-    fetchComplete: rdxActionCreator('@ghProfile.fetchComplete').withPayload<GithubUserDto>(),
-    fetchError: rdxActionCreator('@ghProfile.fetchError').withPayload<object>(),
+    fetchComplete: rdxActionCreator('@gh-profile/fetch-complete').withPayload<GithubUserDto>(),
+    fetchError: rdxActionCreator('@gh-profile/fetch-error').withPayload<object>(),
 } as const
 
 type ActionsObject = typeof ghProfileActions

diff --git a/src/app/modules/github-profile/state/github-profile.epics.ts b/src/app/modules/github-profile/state/github-profile.epics.ts
@@ -7,7 +7,7 @@ const DEFAULT_USERNAME = 'rodmax'
 
 export const ghProfileFetchDataEpic: Epic<GhProfileAnyAction> = action$ => {
     return action$.pipe(
-        ofType('@ghProfile.fetchRequested'),
+        ofType('@gh-profile/fetch-requested'),
         switchMap(action => {
             return ghProfileApiClient.getProfile(action.payload.username).pipe(
                 map(userDto => {