Emit 'logRemoved' event for files which are removed from disk #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e actually removed from disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this library is not emitting
logRemovedevent for files inside Audit JSON which are actually deleted from disk.This causes issues for example in
winston-daily-rotate-filewhich is providing gzip functionality and it compresses the original log files and then removes them from disk.Now, because this remove event is not emitted winston-daily-rotate-file cannot delete those
.gzfiles.It is safe to emit this event because original log file is deleted. Whether deletion is done by file-stream-rotator or someone else.