Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testscript: fix "signal: killed" exec errors on MacOS by doing a full copy of binaries #220

Closed
wants to merge 1 commit into from
Closed

testscript: fix "signal: killed" exec errors on MacOS by doing a full copy of binaries #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion testscript/exe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ func RunMain(m TestingM, commands map[string]func() int) (exitCode int) {
// unix-like setups. Note that "go test" also places test binaries in the
// system's temporary directory, like we do. We don't use hard links on Windows,
// as that can lead to "access denied" errors when removing.
// We also currently don't use hard links on macOS, see issue #200.
func copyBinary(from, to string) error {
if runtime.GOOS != "windows" {
if runtime.GOOS != "windows" && runtime.GOOS != "darwin" {
if err := os.Link(from, to); err == nil {
return nil
}
Expand Down