Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub PR Issue Checker Workflow #147

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

smog-root
Copy link
Contributor

@smog-root smog-root commented Oct 20, 2024

Closes #146

Usage:

  1. When a pull request is created or edited, the workflow automatically triggers.

  2. The workflow checks for:

  • A non-empty PR description.
  • A valid issue reference format (Fixes , Close, Closes, Closed , Fix , Fixed , Resolve , Resolves #Issue_number).
  1. If either check fails, the PR will be marked as failing, and the author will receive clear error messages in the PR comments.
  2. If all checks pass, a confirmation message will indicate that the PR is valid.

Note: Kindly add all the labels added to the issue, to this PR!

@rohitinu6

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the PR matches the requirements mentioned in the Contribution guide. The maintainer might get in touch to enusre quality. Thanks for your time

@smog-root
Copy link
Contributor Author

Add labels!! And assign me!

@rohitinu6
Copy link
Owner

@smog-root mentors will review and merge the PR

@smog-root
Copy link
Contributor Author

@smog-root mentors will review and merge the PR

You can add the labels right??

@Mayureshd-18
Copy link
Collaborator

@smog-root mentors will review and merge the PR

You can add the labels right??

I will add the labels after my review.

@Mayureshd-18 Mayureshd-18 self-requested a review October 20, 2024 15:04
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smog-root Please link the issue using keywords. (fixes/closes..) You can find the detailed info about the same here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

If needed, please check out merged PRs for reference.

Thanks & regards

@smog-root
Copy link
Contributor Author

@Mayureshd-18 changes done! ✅

@smog-root
Copy link
Contributor Author

smog-root commented Oct 20, 2024

You can review now I added

close

closes

closed

fix

fixes

fixed

resolve

resolves

resolved

@Mayureshd-18
Copy link
Collaborator

@smog-root Don't change the workflow jobs. I meant to change the PR description to link the issue by using keywords. (fixes/closes). Please check other PRs that are merged for reference.

@smog-root
Copy link
Contributor Author

@Mayureshd-18 is it okay now!??

@jvedsaqib
Copy link
Collaborator

@Mayureshd-18 is it okay now!??

@smog-root Edit your first comment.
The word 'closes' is styled as **\closes**.
Remove the asterisks.

@smog-root
Copy link
Contributor Author

@jvedsaqib done 👍

@Mayureshd-18 Mayureshd-18 self-requested a review October 20, 2024 15:34
Copy link
Collaborator

@Mayureshd-18 Mayureshd-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@smog-root
Copy link
Contributor Author

@Mayureshd-18 add labels and merge!

@Mayureshd-18 Mayureshd-18 added gssoc-ext GSSoC'24 Extended Version hacktoberfest-accepted Hacktoberfest 2024 level1 10 Points 🥇(GSSoC) hacktoberfest Hacktober Collaboration labels Oct 20, 2024
@smog-root
Copy link
Contributor Author

@Mayureshd-18 it's level2 on issue!

@smog-root
Copy link
Contributor Author

don't decrease the level!

@smog-root
Copy link
Contributor Author

Add level2 label @rohitinu6

@rohitinu6 rohitinu6 added level2 25 Points 🥈(GSSoC) and removed level1 10 Points 🥇(GSSoC) labels Oct 20, 2024
@Mayureshd-18 Mayureshd-18 merged commit 3f4c2ef into rohitinu6:main Oct 20, 2024
2 of 5 checks passed
@MastanSayyad MastanSayyad added level1 10 Points 🥇(GSSoC) and removed level2 25 Points 🥈(GSSoC) labels Oct 27, 2024
Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows = level 1

@MastanSayyad MastanSayyad removed the level1 10 Points 🥇(GSSoC) label Oct 27, 2024
@smog-root
Copy link
Contributor Author

@MastanSayyad why you removed level label?? Add level1!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PR Issue Checker Workflow
5 participants