-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SMA and EMA calculations #40
Conversation
Added SMA and EMA calculations to the stock price prediction model 1. Implemented calculations for Simple moving average and exponential moving average to improve the model's predictive abilities..
The issue was #16 |
@AnsharaFayazBeigh you created a new notebook? |
Yes I did! @jvedsaqib |
@rohitinu6 Please review It! |
@AnsharaFayazBeigh can you do the changes on the actual notebook itself? Please star the repo if you haven't |
@jvedsaqib Thanks for the feedback! I’ve been using Google Colab for the notebook, and I ended up having to create a new one to make everything work. Because of that, I can’t update the original notebook directly. Do you have any suggestions on how I can merge my changes, or what I should do next? I’d really appreciate any help! Thanks so much! I did star the repo! |
This PR addresses the issue #16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnsharaFayazBeigh Please sync your branch with the latest changes. There maybe chances of conflict which are not reflecting now. After sync if there are no conflicts will merge the PR.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this PR due to long period of inactivity. Please feel free to re-open in case needed.
Thanks,
Mayuresh
Closes #16
Issue Reference: #16
I have put the updated file where I have put the SMA and EMA calculations!
Added SMA and EMA calculations to the stock price prediction model
Implemented calculations for Simple moving average and exponential moving average to improve the model's predictive abilities..