Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SecurityCapabilities in rbx_binary #361

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Implement SecurityCapabilities in rbx_binary #361

merged 5 commits into from
Sep 21, 2023

Conversation

kennethloeffler
Copy link
Member

This PR implements SecurityCapabilities parsing in rbx_binary. I chose to use read_interleaved_i64_array and write_interleaved_i64_array because Roblox appears to serialize it this way, and it's straightforward enough to cast between u64 and i64.

@kennethloeffler kennethloeffler merged commit c925260 into rojo-rbx:master Sep 21, 2023
2 checks passed
@kennethloeffler kennethloeffler deleted the rbx-binary-security-capabilities branch September 21, 2023 19:53
@kennethloeffler kennethloeffler mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennethloeffler @Dekkonot