Implement method for cloning multiple instances into external dom #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a consumer to clone multiple instances into an external dom and preserve refs that point across the cloned instance subtrees
Dekkonot
requested changes
Sep 25, 2023
Dekkonot
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: lune-org/lune#110
It is not possible to preserve refs that point across subtrees using
WeakDom::clone_into_externalbecause a newCloneContextis used for each invocation - this new method gives a way to use oneCloneContextfor multiple subtrees!Not sure about the method name, docs could probably be a little better, etc.