Skip to content

Commit

Permalink
Merge pull request #289 from sergiozeppo/sergiozeppo/pr-review-fix
Browse files Browse the repository at this point in the history
fix: fix links in pr-review-process
  • Loading branch information
dzmitry-varabei authored Aug 22, 2024
2 parents 9757e94 + f9370f6 commit e3d1fc4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions docs/en/pull-request-review-process.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

1. A student completes an assignment in a school's private repository (unless otherwise specified in a task description).
2. The student creates and submits a Pull Request before the deadline.
- The PR rules are specified [below](https://docs.app.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following)
- Penalties for deadline violations are listed [below](https://docs.app.rs.school/#/pull-request-review-process?id=Deadlines-for-Students)
- The PR rules are specified [below](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following)
- Penalties for deadline violations are listed [below](https://docs.rs.school/#/en/pull-request-review-process?id=deadlines-for-students)
3. Until the final grade is given by the mentor, the student can continue to implement remaining features
4. The mentor checks the PR, leaves his comments and recommendations on the quality of the code (copy-paste, magic numbers, project structure, etc.) and the implemented functionality. Leaves a comment with a preliminary score.
- The score is set by the mentor based on the assessment criteria specified for each task
Expand Down Expand Up @@ -38,7 +38,7 @@ Pull Request is a place to discuss contributor's code. It should not be a monolo
```
1. Task: https://github.com/rolling-scopes-school/tasks/blob/master/tasks/fancy-weather.md
2. Screenshot:
![](https://docs.app.rs.school/images/fancy-weather.png)
![](https://docs.rs.school/images/fancy-weather.png)
3. Deployment: https://chakapega-fancy-weather.netlify.com/
4. Done 28.05.2020 / deadline 31.05.2020
5. Score: 220 / 300
Expand Down Expand Up @@ -77,8 +77,8 @@ This approach solves several problems that are usually encountered when reviewin

1. Code Review process can be started with a check of the PR format, the naming of the commits, and a sufficient number of them.

- [Commit Requirements](https://docs.app.rs.school/#/git-convention)
- [Pull Request Requirements](https://https://docs.app.rs.school/#/pull-request-review-process?id=Pull-Request-description-must-contain-the-following)
- [Commit Requirements](https://docs.rs.school/#/en/git-convention)
- [Pull Request Requirements](https://docs.rs.school/#/en/pull-request-review-process?id=pull-request-description-must-contain-the-following)

2. Next, clone the repository, install dependencies, and check if the project is buildable / runnable.

Expand Down

0 comments on commit e3d1fc4

Please sign in to comment.