Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add personal mentoring dates #2587

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

karlovich
Copy link
Collaborator

@karlovich karlovich commented Jan 31, 2025

🟒 Add deploy label if you want to deploy this Pull Request to staging environment

πŸ§‘β€βš–οΈ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

πŸ”— Related issue link

#2586

πŸ’‘ Background and solution

Two additional fields for

  • UI changed
  • DTOs changed
  • Migration script added
  • Backup sql updated
  • Openapi updated

β˜‘οΈ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@karlovich karlovich self-assigned this Jan 31, 2025
@karlovich karlovich marked this pull request as draft January 31, 2025 13:21
Copy link

github-actions bot commented Jan 31, 2025

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (500 KB)
/admin/courses 399.37 KB 475.57 KB 95.11% (🟑 +0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@valerydluski valerydluski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@valerydluski valerydluski marked this pull request as ready for review February 2, 2025 20:11
@karlovich karlovich marked this pull request as draft February 3, 2025 08:16
@karlovich karlovich marked this pull request as ready for review February 3, 2025 14:21
@karlovich
Copy link
Collaborator Author

@valerydluski could you pls re-review the PR, I did changes in export dto for having the dates in CDN/app/courses.json for using the mentoring dates in RS WEB site and also reset the personal mentoring start/end dates to null if personalMentoring is false for the data consistency. tested locally, no issues found. Changes for exporting to CDN could vefiry only at prod env after the merge.

@karlovich karlovich linked an issue Feb 3, 2025 that may be closed by this pull request
@karlovich karlovich merged commit d150703 into master Feb 4, 2025
6 checks passed
@karlovich karlovich deleted the feature/add-personal-mentoring-dates branch February 4, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add start/end dates for the personal mentoring in the course data
3 participants