Option to ignore SSL certificate #397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1504
reviewed
Jan 29, 2024
| @@ -43,7 +44,10 @@ def download_image(row, timeout, user_agent_token, disallowed_header_directives) | |||
| user_agent_string += f" (compatible; {user_agent_token}; +https://github.com/rom1504/img2dataset)" | |||
| try: | |||
| request = urllib.request.Request(url, data=None, headers={"User-Agent": user_agent_string}) | |||
| with urllib.request.urlopen(request, timeout=timeout) as r: | |||
| ctx = ssl.create_default_context() | |||
There was a problem hiding this comment.
you are not using the new option here
There was a problem hiding this comment.
Oups my bad, should be fixed :)
|
@rom1504 It would be nice to have the ignore_ssl_certificate option soon for avoiding SSL errors when downloading any dataset. What modifications are still needed to merge this PR into main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.