Dev/rsearch #1
Dev/rsearch #1
Conversation
|
It seems that most of the code here is actually someone else's code that's been included as is. Or has it been changed here and there? I can't be sure. Is this the best way that 3rd party packages can be handled in Go? If so, this is deeply troubling. |
|
The Romana files here don't have any file or package comments, or even license headers and most function and type docstrings are missing as well. Can I assume that all of this will be added soon? |
| "net/http" | ||
| ) | ||
|
|
||
| // SearchResource connects to instance of a server |
| @@ -0,0 +1 @@ | |||
| vendor/ | |||
There was a problem hiding this comment.
They seem to use godeps instead of vendoring, so this probably isn't needed.
There was a problem hiding this comment.
I maintain godep directory, but with VENDOREXPERIMENT vendor/ folder gets created automatically. This line is to prevent accidental commits including this folder.
| @@ -0,0 +1,18 @@ | |||
| ; comment | |||
| [api] | |||
| url=http://192.168.0.10:8080 | |||
There was a problem hiding this comment.
Couldn't this just be watchURL as a single item? Does it actually vary between deployments?
There was a problem hiding this comment.
Kube api url does change, namespace endpoint might not change but we want to be able to define api url separately as it's going to be used in few places.
| } | ||
|
|
||
| // Assembling response. | ||
| for NPid, _ := range search[string(req.Tag)] { |
There was a problem hiding this comment.
All the map accesses are going to be racey.
There was a problem hiding this comment.
Process goroutine owns all the maps and it can perform only one task at a time.
we either writing or reading, not both at same time
case e := <-in:
// On incoming event update caches
updateStorage(e, storage, search, config)
case request := <-req:
// On incoming search request return a list
// of resources with matching Selectors
processSearchRequest(storage, search, request, config)
|
|
||
| package rsearch | ||
|
|
||
| func manageResources(ns Event, terminators map[string]chan Done, config Config, out chan Event) { |
|
The code here is quite involved, with lots of moving parts. I would really like to see some explanatory docstring somewhere, possibly even a chapter in the README, which explains the architecture and all the various bits and parts. As it is right now, the code is unpleasant, since without a big picture you'll have a hard time making sense of it. So, please add some explanatory docstring about the architecture somewhere. |
| "encoding/json" | ||
| ) | ||
|
|
||
| func TestResoureProcessor(t *testing.T) { |
Reverse search
This is a utility for reverse search in kubernetes (find all objects who select given label).
Usage
Provided binary can act as either client or server depending on command line options.
Server instance connects to Kubernetes API and monitors resource changes
Client then can query the server
-rlabel to query,#sign is not a part of a label but terminator that need to be added to request (TODO at this point i'm not really sure it's needed)-hurl address where server instance is running