feat(project): support ignore files for eslint and prettier (#1577)

rome · Jun 18, 2021 · 0c870f6 · 0c870f6
1 parent df2fc45
commit 0c870f6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/internal/project/constants.ts b/internal/project/constants.ts
@@ -23,6 +23,11 @@ export const PRETTIER_CONFIG_FILESNAMES: string[] = [
 	".prettierr.json5",
 ];
 
+export const INTEGRATIONS_IGNORE_FILES: string[] = [
+	".prettierignore",
+	".eslintignore",
+];
+
 export const PROJECT_CONFIG_PACKAGE_JSON_FIELD = "rome";
 export const PROJECT_CONFIG_DIRECTORY = ".config";
 export const PROJECT_CONFIG_FILENAMES: string[] = [];

diff --git a/internal/project/load.ts b/internal/project/load.ts
@@ -31,6 +31,7 @@ import {CachedFileReader} from "@internal/fs";
 import {parseSemverRange} from "@internal/codec-semver";
 import {descriptions} from "@internal/diagnostics";
 import {
+	INTEGRATIONS_IGNORE_FILES,
 	PRETTIER_CONFIG_FILESNAMES,
 	PROJECT_CONFIG_PACKAGE_JSON_FIELD,
 	VCS_IGNORE_FILENAMES,
@@ -119,6 +120,7 @@ export async function loadCompleteProjectConfig(
 	// Load extensions configuration of prettier
 	for (const prettierFile of PRETTIER_CONFIG_FILESNAMES) {
 		const possiblePath = projectDirectory.append(prettierFile);
+		meta.configDependencies.add(possiblePath);
 		if (await possiblePath.exists()) {
 			const file = await reader.readFileText(possiblePath);
 			const prettierConfig = loadPrettier(file, possiblePath.getExtensions());
@@ -129,6 +131,24 @@ export async function loadCompleteProjectConfig(
 		}
 	}
 
+	// read ignore files
+	for (const fileToIgnore of INTEGRATIONS_IGNORE_FILES) {
+		const possiblePath = projectDirectory.append(fileToIgnore);
+		meta.configDependencies.add(possiblePath);
+		if (await possiblePath.exists()) {
+			const file = await reader.readFileText(possiblePath);
+
+			consumer.handleThrownDiagnostics(() => {
+				const patterns = parsePathPatternsFile({
+					input: file,
+					path: possiblePath,
+				});
+
+				config.lint.ignore = [...config.lint.ignore, ...patterns];
+			});
+		}
+	}
+
 	// Calculate config hash keys
 	await Promise.all(
 		Array.from(