Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(cli): init command #1521

Merged
merged 1 commit into from
May 21, 2021
Merged

fix(cli): init command #1521

merged 1 commit into from
May 21, 2021

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented May 20, 2021

Summary

Fixes #1515

There were few issues that I fixed here:

  • the check on arguments is now dropped, because it's not needed;
  • fixed the check hasProject.data;
  • handled the case where the user inserts 0 as value for the tab size;
  • add manually the project to the ProjectManager;
  • changed the way the manifest of the project is retrieved. Before, we were interrogating the file system, although now we can't retrieve anymore from there (probably it changed recently). We now retrieve the manifest manually as we already have all the information we need;
  • defaulting some values inside the .editorconfig. This fixes the case where we have empty a project with no files at all, Rome would create an empty file, which is not what we want. So, in case we don't have any extension, we set some defaults.

Test Plan

Manually checked

@ematipico ematipico requested a review from sebmck as a code owner May 20, 2021 07:04
@ematipico ematipico merged commit aa1563e into rome:main May 21, 2021
@ematipico ematipico deleted the bugfix/init-command branch May 21, 2021 07:44
sergeypriakhin pushed a commit to sergeypriakhin/tools that referenced this pull request Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant