Simplify file fetching loop

romeovs · Mar 6, 2020 · 4c67927 · 4c67927
1 parent 6668b90
commit 4c67927
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 44 deletions.
diff --git a/dist/main.js b/dist/main.js
@@ -22922,30 +22922,22 @@ async function changedFiles(github, repo, pr, count) {
 	const files = [];
 
 	for (const page = 0; page * perPage < count; page++) {
-		await Promise.all(
-			commits.map(async function(commit) {
-				if (!commit.distinct) {
-					return
-				}
-
-				const response = await github.pulls.listFiles({
-					...repo,
-					pull_number: pr,
-					page,
-					per_page: perPage,
-				});
+		const response = await github.pulls.listFiles({
+			...repo,
+			pull_number: pr,
+			page,
+			per_page: perPage,
+		});
 
-				if (!response || !response.data) {
-					return
-				}
+		if (!response || !response.data) {
+			return
+		}
 
-				for (const file of result.data) {
-					if (file.status === "added" || file.status === "modified") {
-						files.push(file.filename);
-					}
-				}
-			}),
-		);
+		for (const file of result.data) {
+			if (file.status === "added" || file.status === "modified" || file.status === "renamed") {
+				files.push(file.filename);
+			}
+		}
 	}
 
 	return files

diff --git a/src/files.js b/src/files.js
@@ -4,30 +4,22 @@ export async function changedFiles(github, repo, pr, count) {
 	const files = []
 
 	for (const page = 0; page * perPage < count; page++) {
-		await Promise.all(
-			commits.map(async function(commit) {
-				if (!commit.distinct) {
-					return
-				}
+		const response = await github.pulls.listFiles({
+			...repo,
+			pull_number: pr,
+			page,
+			per_page: perPage,
+		})
 
-				const response = await github.pulls.listFiles({
-					...repo,
-					pull_number: pr,
-					page,
-					per_page: perPage,
-				})
+		if (!response || !response.data) {
+			return
+		}
 
-				if (!response || !response.data) {
-					return
-				}
-
-				for (const file of result.data) {
-					if (file.status === "added" || file.status === "modified") {
-						files.push(file.filename)
-					}
-				}
-			}),
-		)
+		for (const file of result.data) {
+			if (file.status === "added" || file.status === "modified" || file.status === "renamed") {
+				files.push(file.filename)
+			}
+		}
 	}
 
 	return files