try prevent percy to run if other test are failings

romgere · Mar 6, 2024 · 951d374 · 951d374
1 parent 6306f21
commit 951d374
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,6 +16,9 @@ jobs:
     - name: Install Dependencies
       run: yarn install --frozen-lockfile
     - name: Test
-      run: yarn percy exec -- ember test
+      run: yarn test:ember
+    - name: Visual Tests
+      if: success()
+      run: yarn percy exec -- yarn test:ember:visual
       env:
         PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
diff --git a/package.json b/package.json
@@ -27,7 +27,8 @@
     "lint:types": "tsc --noEmit --composite false",
     "start": "ember serve",
     "test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
-    "test:ember": "ember test",
+    "test:ember": "ember test --filter=\"!Visual\"",
+    "test:ember:visual": "ember test --filter=\"Visual\"",
     "generate:type_img": "misc/text_type/generate_logo.sh"
   },
   "devDependencies": {

diff --git a/tests/acceptance/visual-test.ts b/tests/acceptance/visual-test.ts
@@ -9,7 +9,7 @@ import mockFontManager from 'text2stl/tests/helpers/mock-font-manager';
 import waitCalciteReady from 'text2stl/tests/helpers/wait-calcite-ready';
 import wait from 'text2stl/tests/helpers/wait';
 
-module('Acceptance | visual', function (hooks) {
+module('Visual | percy', function (hooks) {
   setupApplicationTest(hooks);
 
   hooks.beforeEach(function () {