Skip to content

Commit

Permalink
restore lint & remove calciteWait log
Browse files Browse the repository at this point in the history
  • Loading branch information
romgere committed Mar 6, 2024
1 parent 6a6d6f6 commit bc20636
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
node-version: '18'
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Lint
run: yarn lint
- name: Test
run: yarn test:ember
- name: Visual Tests
Expand Down
4 changes: 2 additions & 2 deletions tests/helpers/wait-calcite-ready.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ const TIME_SINCE_LAST_MUTATION = 1000;
export default async function waitCalciteReady(
opt: { timeout: number } = { timeout: MAX_TIMEOUT },
) {
const start = new Date();
// const start = new Date();

// This does not seems to work as expected
await waitAllCalciteComponentReady();
// Use some workaround based on mutation observer to wait for page mutation end.
await uiSettled(opt.timeout);

console.log('waitCalciteReady DONE', new Date().getTime() - start.getTime());
// console.log('waitCalciteReady DONE', new Date().getTime() - start.getTime());
}

async function waitAllCalciteComponentReady() {
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/components/settings-form/font-test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render, click, triggerEvent, settled, waitFor } from '@ember/test-helpers';
import { render, click, triggerEvent, settled } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';
import { setComponentTemplate } from '@ember/component';
import { tracked } from '@glimmer/tracking';
Expand Down

0 comments on commit bc20636

Please sign in to comment.