-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAA1064 and Seven Segment display APIs #41
Open
stuartervine
wants to merge
17
commits into
romilly:master
Choose a base branch
from
stuartervine:saa1064
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he PinBank model for this. [SE]
… that using Output wrapper objects. [SE]
… be set directly on the pin bank. [SE]
…A1064 (these are tied to the chip). [SE]
…, and a writable byte for all configuration. [SE]
…r around the SAA1064. Still need to add some protection to it. [SE]
…sed digits, and configured on first write. [SE]
…essary calls. [SE]
@@ -0,0 +1,17 @@ | |||
__author__ = 'stuartervine' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a consistent naming convention for programs in the examples directory? Hyphens, not underscores, to separate words and no .py suffix (makes working at the command-line more convenient). Also they should be executable and start with the line "#!/usr/bin/env python3"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated API based off conversations with Nat last Tuesday.
Deferred configuration to first data write to the chip. This means it's impossible to forget to configure the chip.
Fixed a problem with padding on displaying strings of length less than the number of digits. For example, displaying '10' on a 4 digit display, used to show '10--' (where - signifies a blank digit). Now it shows '--10'.