Skip to content

Commit

Permalink
Expected bytes error message and imports cleanup (#400)
Browse files Browse the repository at this point in the history
* Format expected bytes error with base64 as in ron

* Reformat imports to be consistent
  • Loading branch information
juntyr authored Aug 16, 2022
1 parent 4089034 commit 75ac75e
Show file tree
Hide file tree
Showing 24 changed files with 65 additions and 45 deletions.
3 changes: 2 additions & 1 deletion examples/decode.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#![allow(dead_code)]

use std::collections::HashMap;

use ron::de::from_str;
use serde::Deserialize;
use std::collections::HashMap;

#[derive(Debug, Deserialize)]
struct Config {
Expand Down
3 changes: 2 additions & 1 deletion examples/decode_file.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#![allow(dead_code)]

use std::{collections::HashMap, fs::File};

use ron::de::from_reader;
use serde::Deserialize;
use std::{collections::HashMap, fs::File};

#[derive(Debug, Deserialize)]
struct Config {
Expand Down
3 changes: 2 additions & 1 deletion examples/encode.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::{collections::HashMap, iter::FromIterator};

use ron::ser::{to_string_pretty, PrettyConfig};
use serde::Serialize;
use std::{collections::HashMap, iter::FromIterator};

#[derive(Serialize)]
struct Config {
Expand Down
2 changes: 1 addition & 1 deletion rustfmt.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
hard_tabs = false
use_field_init_shorthand = true
use_try_shorthand = true
edition = "2018"
edition = "2021"
4 changes: 2 additions & 2 deletions src/de/mod.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/// Deserialization module.
pub use crate::error::{Error, Position, SpannedError};
use std::{borrow::Cow, io, str};

use serde::de::{self, DeserializeSeed, Deserializer as SerdeError, Visitor};
use std::{borrow::Cow, io, str};

use self::{id::IdDeserializer, tag::TagDeserializer};
pub use crate::error::{Error, Position, SpannedError};
use crate::{
error::{Result, SpannedResult},
extensions::Extensions,
Expand Down
3 changes: 2 additions & 1 deletion src/de/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ fn err<T>(kind: Error, line: usize, col: usize) -> SpannedResult<T> {

#[test]
fn test_err_wrong_value() {
use self::Error::*;
use std::collections::HashMap;

use self::Error::*;

assert_eq!(from_str::<f32>("'c'"), err(ExpectedFloat, 1, 1));
assert_eq!(from_str::<String>("'c'"), err(ExpectedString, 1, 1));
assert_eq!(from_str::<HashMap<u32, u32>>("'c'"), err(ExpectedMap, 1, 1));
Expand Down
9 changes: 6 additions & 3 deletions src/de/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ use serde::{
Deserialize, Deserializer,
};

use crate::error::SpannedResult;
use crate::value::{Map, Number, Value};
use crate::{
error::SpannedResult,
value::{Map, Number, Value},
};

impl std::str::FromStr for Value {
type Err = crate::error::SpannedError;
Expand Down Expand Up @@ -181,9 +183,10 @@ impl<'de> Visitor<'de> for ValueVisitor {

#[cfg(test)]
mod tests {
use super::*;
use std::str::FromStr;

use super::*;

fn eval(s: &str) -> Value {
s.parse().expect("Failed to parse")
}
Expand Down
15 changes: 5 additions & 10 deletions src/error.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use serde::{de, ser};
use std::{error::Error as StdError, fmt, io, str::Utf8Error, string::FromUtf8Error};

use serde::{de, ser};

/// This type represents all possible errors that can occur when
/// serializing or deserializing RON data.
#[derive(Clone, Debug, PartialEq, Eq)]
Expand Down Expand Up @@ -276,15 +277,9 @@ impl de::Error for Error {
Float(n) => write!(f, "the floating point number `{}`", n),
Char(c) => write!(f, "the UTF-8 character `{}`", c),
Str(s) => write!(f, "the string {:?}", s),
Bytes(b) => {
f.write_str("the bytes b\"")?;

for b in b {
write!(f, "\\x{:02x}", b)?;
}

f.write_str("\"")
}
Bytes(b) => write!(f, "the bytes \"{}\"", {
base64::display::Base64Display::with_config(b, base64::STANDARD)
}),
Unit => write!(f, "a unit value"),
Option => write!(f, "an optional value"),
NewtypeStruct => write!(f, "a newtype struct"),
Expand Down
10 changes: 6 additions & 4 deletions src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ use std::io;

use serde::{de, ser, Deserialize, Serialize};

use crate::de::Deserializer;
use crate::error::{Result, SpannedResult};
use crate::extensions::Extensions;
use crate::ser::{PrettyConfig, Serializer};
use crate::{
de::Deserializer,
error::{Result, SpannedResult},
extensions::Extensions,
ser::{PrettyConfig, Serializer},
};

/// Roundtrip serde options.
///
Expand Down
3 changes: 2 additions & 1 deletion src/ser/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use serde::{ser, Deserialize, Serialize};
use std::io;

use serde::{ser, Deserialize, Serialize};

use crate::{
error::{Error, Result},
extensions::Extensions,
Expand Down
3 changes: 2 additions & 1 deletion src/ser/tests.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use super::to_string;
use serde::Serialize;

use super::to_string;

#[derive(Serialize)]
struct EmptyStruct1;

Expand Down
9 changes: 5 additions & 4 deletions src/value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ use serde::{
forward_to_deserialize_any, Deserialize, Serialize,
};

use crate::de::Error;
use crate::error::Result;
use crate::{de::Error, error::Result};

/// A `Value` to `Value` map.
///
Expand Down Expand Up @@ -484,10 +483,12 @@ impl<'de> SeqAccess<'de> for Seq {

#[cfg(test)]
mod tests {
use super::*;
use serde::Deserialize;
use std::{collections::BTreeMap, fmt::Debug};

use serde::Deserialize;

use super::*;

fn assert_same<'de, T>(s: &'de str)
where
T: Debug + Deserialize<'de> + PartialEq,
Expand Down
3 changes: 2 additions & 1 deletion tests/123_enum_representation.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::{cmp::PartialEq, fmt::Debug};

use ron::{de::from_str, ser::to_string};
use serde::{Deserialize, Serialize};
use std::{cmp::PartialEq, fmt::Debug};

#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
enum Inner {
Expand Down
3 changes: 2 additions & 1 deletion tests/147_empty_sets_serialisation.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use serde::{Deserialize, Serialize};
use std::collections::HashMap;

use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Deserialize, Serialize)]
struct UnitStruct;

Expand Down
5 changes: 4 additions & 1 deletion tests/250_variant_newtypes.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
use std::collections::HashMap;

use ron::{
de::from_str, error::Error, extensions::Extensions, ser::to_string_pretty, ser::PrettyConfig,
de::from_str,
error::Error,
extensions::Extensions,
ser::{to_string_pretty, PrettyConfig},
};
use serde::{Deserialize, Serialize};

Expand Down
3 changes: 2 additions & 1 deletion tests/depth_limit.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use serde::Serialize;
use std::collections::HashMap;

use serde::Serialize;

#[derive(Serialize)]
struct Config {
float: (f32, f64),
Expand Down
3 changes: 2 additions & 1 deletion tests/escape.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::{char::from_u32, fmt::Debug};

use ron::{de::from_str, ser::to_string};
use serde::{Deserialize, Serialize};
use std::{char::from_u32, fmt::Debug};

#[test]
fn test_escape_basic() {
Expand Down
3 changes: 2 additions & 1 deletion tests/extensions.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use serde::{Deserialize, Serialize};
use std::collections::HashMap;

use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Deserialize, Serialize)]
struct UnitStruct;

Expand Down
6 changes: 4 additions & 2 deletions tests/numbers.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use ron::de::from_str;
use ron::error::{Error, Position, SpannedError};
use ron::{
de::from_str,
error::{Error, Position, SpannedError},
};

#[test]
fn test_hex() {
Expand Down
3 changes: 1 addition & 2 deletions tests/options.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use serde::{Deserialize, Serialize};

use ron::{extensions::Extensions, ser::PrettyConfig, Options};
use serde::{Deserialize, Serialize};

#[derive(Serialize, Deserialize)]
struct Newtype(f64);
Expand Down
3 changes: 2 additions & 1 deletion tests/preserve_sequence.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
use std::collections::BTreeMap;

use ron::{
de::from_str,
ser::{to_string_pretty, PrettyConfig},
};
use serde::{Deserialize, Serialize};
use std::collections::BTreeMap;

#[derive(Debug, Deserialize, Serialize)]
struct Config {
Expand Down
2 changes: 1 addition & 1 deletion tests/roundtrip.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use serde::{Deserialize, Serialize};
use std::collections::HashMap;

use ron::extensions::Extensions;
use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Deserialize, Serialize)]
struct UnitStruct;
Expand Down
6 changes: 4 additions & 2 deletions tests/to_string_pretty.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use ron::ser::{to_string_pretty, PrettyConfig};
use ron::to_string;
use ron::{
ser::{to_string_pretty, PrettyConfig},
to_string,
};
use serde::{Deserialize, Serialize};

#[derive(Debug, PartialEq, Deserialize, Serialize)]
Expand Down
3 changes: 2 additions & 1 deletion tests/value.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use std::f64;

use ron::value::{Map, Number, Value};
use serde::Serialize;
use std::f64;

#[test]
fn bool() {
Expand Down

0 comments on commit 75ac75e

Please sign in to comment.