Use Self TypeVar for SSHConnection __aenter__ #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that when using a subclass as a context manager like so: async with asyncssh.connect(...) as con: the con variable has the type SSHClientConnection instead of simply SSHConnection.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #600 +/- ##
========================================
Coverage 99.84% 99.84%
========================================
Files 93 93
Lines 26808 26809 +1
Branches 2797 2797
========================================
+ Hits 26767 26768 +1
Misses 38 38
Partials 3 3
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
ronf
reviewed
Nov 12, 2023
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that when using a subclass as a context manager like so:
the
convariable has the typeSSHClientConnectioninstead of simplySSHConnection.This is equivalent to the
typing.Selftype introduced in Python 3.11, but backwards compatible.