Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly inline field values #137

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Correctly inline field values #137

merged 2 commits into from
Feb 6, 2025

Conversation

leo
Copy link
Member

@leo leo commented Feb 6, 2025

This change ensures that statement parameters are correctly inlined when the inlineParams config option is used.

Previously, booleans and integers were incorrectly inlined as strings, for example.

@leo leo added the enhancement New feature or request label Feb 6, 2025
@leo leo requested review from NuroDev, juriadams and colodenn February 6, 2025 17:14
Copy link

github-actions bot commented Feb 6, 2025

Released an experimental package:

bun add @ronin/compiler@leo-ron-1099-1-experimental-367

This package will be removed after the pull request has been merged.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utils/statement.ts 100.00% <100.00%> (ø)

@leo leo marked this pull request as ready for review February 6, 2025 17:15
@leo leo changed the title Correctly inline boolean field values Correctly inline field values Feb 6, 2025
@leo leo enabled auto-merge (squash) February 6, 2025 17:15
@leo leo merged commit 0806bef into main Feb 6, 2025
4 checks passed
@leo leo deleted the leo/ron-1099-1 branch February 6, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants