Add route for inspecting sidekiq jobs #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
requested changes
Nov 7, 2023
app.rb
Outdated
| args: payload["args"], | ||
| created_at: Time.at(payload["created_at"]), | ||
| enqueued_at: Time.at(payload["enqueued_at"]), | ||
| run_at: Time.at(worker["run_at"]) |
There was a problem hiding this comment.
Vertically align the values of the Hash.
| get '/queue' do | ||
| @workers = Sidekiq::Workers.new.map do |_p, _t, worker| | ||
| payload = JSON.parse(worker["payload"]) | ||
| { |
There was a problem hiding this comment.
Add a newline between 774 and 775.
config/sidekiq.rb
Outdated
| @@ -1,5 +1,6 @@ | |||
| # frozen_string_literal: true | |||
| require 'sidekiq' | |||
| require 'sidekiq/api' | |||
There was a problem hiding this comment.
Move this require into app.rb, since that's the only play we use the Sidekiq::API.
|
This is awesome. I'll open separate tickets for some other ideas, like listing currently running jobs at the top, or adding a JavaScript async refresh. |
|
Current design of this view may not be the best you've ever seen, but imo is enough for now. |
postmodern
requested changes
Nov 8, 2023
postmodern
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8